Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve thead overlay issue on scroll - issue #92 #102

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

ArnaudBD
Copy link
Contributor

Fixes #92

Copy link
Contributor

@mazurroman mazurroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArnaudBD thank you for your contribution!

I can confirm it works well in the default state but there is a new bug now: the table header is visible over a modal window. Try opening the program arguments helper (the "?" icon under the cairo editor component).

See screenshot attached. Can you update the PR so that the modal overlaps all content, including the table header?

CleanShot 2024-03-18 at 15 52 40@2x

@ArnaudBD
Copy link
Contributor Author

ArnaudBD commented Mar 18, 2024

Thank for your review @mazurroman and sorry for creating a new bug... I changed the zIndex to 1 instead of 2 so the thead still on top of the other lines but not on top of the modals

@mazurroman
Copy link
Contributor

@ArnaudBD I just tried on my localhost and the menubar is still on top of the modal 🤔 I am using Chrome on Mac...

@ArnaudBD
Copy link
Contributor Author

I've used ReactDOM.createPortal which seems to be a good way to make sure a modal is correctly z indexed. It works in Chrome and Mozilla on my linux.

@barabanovro barabanovro self-requested a review March 20, 2024 10:18
Copy link
Contributor

@barabanovro barabanovro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mazurroman mazurroman merged commit 3c09008 into walnuthq:main Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[easy] [frontend] [od hack] bug: Execution trace header is over the trace when scrolling
3 participants