Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Complete UI Refresh with Material Design Theming #820

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cognition9144
Copy link

@cognition9144 cognition9144 commented Aug 26, 2019

Fixes #809

Other functionalities are working.
A lot of refactorations have been done. Some are not in the most decent way. Some fixes are required as showed above, but I probably not have that much time recently. Maybe @msfjarvis would like to help?

If anyone wants to boost this, you may Donate using Liberapay

@msfjarvis
Copy link

Maybe @msfjarvis would like to help?

Absolutely. If you rebase this on current master I'd definitely like to take a peek tonight.

@cognition9144 cognition9144 force-pushed the xcffl/ui-refresh branch 2 times, most recently from 48b4a7e to c0afbac Compare August 27, 2019 10:04
@tcitworld
Copy link
Member

tcitworld commented Aug 27, 2019

  • Check why Travis doesn't build anymore
  • Remove the q file added.

…rary natively

Replace with Material Design Theming templete
Replace with vector icons
Add customized typography

Signed-off-by: xcffl <[email protected]>
@cognition9144
Copy link
Author

I think it's fixed now

@Strubbl
Copy link
Contributor

Strubbl commented Aug 30, 2019

There is a conflict in app/build.gradle .
Is it really necessary to increase minSDK from 21 to 24? That would be from Android 5 to 7.

@cognition9144
Copy link
Author

cognition9144 commented Aug 31, 2019

There is a conflict in app/build.gradle .

Will, maybe it needs to be merged sooner before more conflicts arrive. @msfjarvis

Is it really necessary to increase minSDK from 21 to 24? That would be from Android 5 to 7.

Not really. This refresh only requires minSDK to be 19. I didn't aware that there were SDK-aware xml. I'll fix it.

@cognition9144
Copy link
Author

I recently have some time to finish this. I'll resolve conflicts and fix the TTS UI first. Of course we need to ensure accessibility.

@cognition9144 cognition9144 changed the title Complete UI Refresh with Material Design Theming [WIP] Complete UI Refresh with Material Design Theming Dec 24, 2019
@di72nn
Copy link
Member

di72nn commented Dec 26, 2019

Thanks, finishing it would be great - I don't think we can do it by ourselves.

@lokesh-krishna
Copy link
Contributor

Are there any screenshots to preview what this looks like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Google's new Material Design Library
6 participants