test: peer exchange testing tool #2940
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from ad15350 |
darshankabariya
changed the title
darshankabariya
force-pushed
the
peer_exchange_tester
branch
from
9e6659a
to
0d87d71
Compare
darshankabariya
force-pushed
the
peer_exchange_tester
branch
from
0d87d71
to
ad1714c
Compare
darshankabariya
force-pushed
the
peer_exchange_tester
branch
from
20fe5da
to
ef14580
Compare
Comment on lines
54
to
81
| let response = await wakuApp.node.wakuPeerExchange.request(5, peer_info) | ||
|
|
||
| if response.isOk: | ||
| var validPeers = 0 | ||
| let peers = response.get().peerInfos | ||
| for pi in peers: | ||
| var record: enr.Record | ||
| if enr.fromBytes(record, pi.enr): | ||
| let peer_info = record.toRemotePeerInfo().get() | ||
| let peerId = peer_info.peerId | ||
| let ma = peer_info.addrs | ||
| echo $iter & ") -----> " & $ma[0] & " -- " & $peerId | ||
| iter += 1 | ||
| try: | ||
| let wait = 20000 | ||
| let conn = await switch | ||
| .dial(peerId, ma, "/vac/waku/metadata/1.0.0") | ||
| .withTimeout(wait) | ||
| except TimeoutError: | ||
| echo "Dialing peer " & $peerId & " timed out." | ||
| except: | ||
| echo "An error occurred while dialing peer " & $peerId | ||
|
|
||
| success += len(switch.connectedPeers(Direction.Out)) | ||
| echo $success & " out of " & $iter & " operation successful" | ||
| discard switch.disconnect(peerId) | ||
| else: | ||
| echo " ------------ response isn't not ok ------------------" |
There was a problem hiding this comment.
In this case we can use valueOr
Suggested change
| let response = await wakuApp.node.wakuPeerExchange.request(5, peer_info) | |
| if response.isOk: | |
| var validPeers = 0 | |
| let peers = response.get().peerInfos | |
| for pi in peers: | |
| var record: enr.Record | |
| if enr.fromBytes(record, pi.enr): | |
| let peer_info = record.toRemotePeerInfo().get() | |
| let peerId = peer_info.peerId | |
| let ma = peer_info.addrs | |
| echo $iter & ") -----> " & $ma[0] & " -- " & $peerId | |
| iter += 1 | |
| try: | |
| let wait = 20000 | |
| let conn = await switch | |
| .dial(peerId, ma, "/vac/waku/metadata/1.0.0") | |
| .withTimeout(wait) | |
| except TimeoutError: | |
| echo "Dialing peer " & $peerId & " timed out." | |
| except: | |
| echo "An error occurred while dialing peer " & $peerId | |
| success += len(switch.connectedPeers(Direction.Out)) | |
| echo $success & " out of " & $iter & " operation successful" | |
| discard switch.disconnect(peerId) | |
| else: | |
| echo " ------------ response isn't not ok ------------------" | |
| let response = await wakuApp.node.wakuPeerExchange.request(5, peer_info).valueOr: | |
| echo " ------------ response isn't not ok ------------------" | |
| var validPeers = 0 | |
| let peers = response.peerInfos | |
| for pi in peers: | |
| var record: enr.Record | |
| if enr.fromBytes(record, pi.enr): | |
| let peer_info = record.toRemotePeerInfo().get() | |
| let peerId = peer_info.peerId | |
| let ma = peer_info.addrs | |
| echo $iter & ") -----> " & $ma[0] & " -- " & $peerId | |
| iter += 1 | |
| try: | |
| let wait = 20000 | |
| let conn = await switch | |
| .dial(peerId, ma, "/vac/waku/metadata/1.0.0") | |
| .withTimeout(wait) | |
| except TimeoutError: | |
| echo "Dialing peer " & $peerId & " timed out." | |
| except: | |
| echo "An error occurred while dialing peer " & $peerId | |
| success += len(switch.connectedPeers(Direction.Out)) | |
| echo $success & " out of " & $iter & " operation successful" | |
| discard switch.disconnect(peerId) | |
| .dial(peerId, ma, "/vac/waku/metadata/1.0.0") | ||
| .withTimeout(wait) | ||
| except TimeoutError: | ||
| echo "Dialing peer " & $peerId & " timed out." |
There was a problem hiding this comment.
Suggested change
| echo "Dialing peer " & $peerId & " timed out." | |
| echo "Dialing peer " & $peerId & " timed out. exc: " & getCurrentExceptionMsg() |
| except TimeoutError: | ||
| echo "Dialing peer " & $peerId & " timed out." | ||
| except: | ||
| echo "An error occurred while dialing peer " & $peerId |
There was a problem hiding this comment.
Suggested change
| echo "An error occurred while dialing peer " & $peerId | |
| echo "An error occurred while dialing peer " & $peerId & " exc: " & getCurrentExceptionMsg() |
| discard switch.disconnect(peerId) | ||
| else: | ||
| echo " ------------ response isn't not ok ------------------" | ||
| sleep(120000) |
There was a problem hiding this comment.
Why we need to wait for so long?
| var iter = 0 | ||
| var success = 0 | ||
| for i in 0 .. 60: | ||
| echo "Seq No :- " & $i & " ---> " |
There was a problem hiding this comment.
I think it is better to always use chronicles. e.g. `debug "Seq No", seq_no = $i
Comment on lines
+44
to
+45
| let addrs = "/ip4/178.128.141.171/tcp/30303/" | ||
| let id = "16Uiu2HAkykgaECHswi3YKJ5dMLbq2kPVCo89fcyTd38UcQD6ej5W" |
There was a problem hiding this comment.
Instead of having a hard-coded value, it should support that from a cli parameter. Nevertheless, let's leave it as is for now and optimize in the future if needed.
| @@ -0,0 +1,86 @@ | |||
| import chronos, chronicles, options, os | |||
There was a problem hiding this comment.
I cannot add a comment in the README.md
The README.md should have content explaining the purpose of the tool and how to use it properly to get the maximum profit of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool helps analyze the peer exchange protocol.