Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Fix macos tests #2539

Draft
wants to merge 3 commits into
base: fix-test-imports
Choose a base branch
from
Draft

Conversation

AlejandroCabeza
Copy link
Contributor

Description

PR to request help and fix the specified tests, which are failing on Mac when ran in Github's runners.

Changes

  • Fixing MacOS tests

@AlejandroCabeza AlejandroCabeza added the help wanted Extra attention is needed label Mar 19, 2024
@AlejandroCabeza AlejandroCabeza self-assigned this Mar 19, 2024
@AlejandroCabeza AlejandroCabeza changed the base branch from master to fix-test-imports March 19, 2024 16:48
@AlejandroCabeza AlejandroCabeza marked this pull request as draft March 19, 2024 16:48
@@ -147,6 +147,12 @@ suite "Waku RlnRelay - End to End":
"WakuRelay protocol is not mounted, cannot mount WakuRlnRelay"

# FIXME: fails on macos
#[
Unhandled defect:
/Users/runner/work/nwaku/nwaku/tests/waku_node/test_wakunode_relay_rln.nim(59, 18)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can probably add a sleep. this is weird since the pr which merged these changes in did not suffer from this. nonceLimit shouldn't be 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing sleep hypothesis.
In any case, there are three different errors, there might be different origins to them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some awaits here and there, not in all failing tests, yet this last run hasn't triggered test failures. There's still an exception:

2024-03-20T15:29:25.3026940Z [Summary] 562 tests run (1018.6s): 554 OK, 0 FAILED, 8 SKIPPED
2024-03-20T15:29:25.8017230Z stack trace: (most recent call last)
2024-03-20T15:29:25.8046630Z /Users/runner/work/nwaku/nwaku/vendor/nimbus-build-system/vendor/Nim/lib/system/nimscript.nim(429, 18)
2024-03-20T15:29:25.8050330Z /Users/runner/work/nwaku/nwaku/waku.nimble(82, 8) testTask
2024-03-20T15:29:25.8051690Z /Users/runner/work/nwaku/nwaku/waku.nimble(54, 8) test
2024-03-20T15:29:25.8053620Z /Users/runner/work/nwaku/nwaku/vendor/nimbus-build-system/vendor/Nim/lib/system/nimscript.nim(273, 7) exec
2024-03-20T15:29:25.8057400Z /Users/runner/work/nwaku/nwaku/vendor/nimbus-build-system/vendor/Nim/lib/system/nimscript.nim(273, 7) Error: unhandled exception: FAILED: build/all_tests_waku [OSError]
2024-03-20T15:29:25.8726590Z make: *** [testwaku] Error 1
2024-03-20T15:29:25.9231280Z ##[error]Process completed with exit code 2.

But I can't figure out what it might be related to. Any ideas?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to initialize the node properly differently for rln-v1 and v2, please see the test_wakunode_rln_relay.nim test

Copy link

github-actions bot commented Mar 20, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2539-rln-v2-false

Built from d675824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants