Update proofConfig.type & cryptosuite test title & expand vectors.

w3c · Jul 2, 2024 · c680b12 · c680b12
1 parent a767782
commit c680b12
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 6 deletions.
diff --git a/tests/setup.js b/tests/setup.js
@@ -144,6 +144,12 @@ export async function verifySetup({credentials, keyTypes, suite}) {
  suiteName: suite,
  generators: [invalidCryptosuite]
  });
+ disclosed.invalid.proofType = await deriveCredentials({
+ keys,
+ vectors: disclosedBasicVectors,
+ suiteName: suite,
+ generators: [invalidProofType]
+ });
  disclosed.invalid.noProofTypeOrCryptosuite = await deriveCredentials({
  keys,
  vectors: disclosedBasicVectors,

diff --git a/tests/suites/verify.js b/tests/suites/verify.js
@@ -95,12 +95,25 @@ export function verifySuite({
  await verificationFail({credential, verifier});
  });
  it('If proofConfig.type is not set to DataIntegrityProof and/or ' +
- 'proofConfig.cryptosuite is not set to bbs-2023, an ' +
- 'INVALID_PROOF_CONFIGURATION error MUST be raised.', async function() {
- this.test.link = 'https://w3c.github.io/vc-di-bbs/#base-proof-transformation-bbs-2023:~:text=If%20proofConfig.type%20is%20not%20set%20to%20DataIntegrityProof%20and/or%20proofConfig.cryptosuite%20is%20not%20set%20to%20bbs%2D2023%2C%20an%20INVALID_PROOF_CONFIGURATION%20error%20MUST%20be%20raised.';
- const credential = cloneTestVector(
- disclosed?.invalid?.proofTypeAndCryptosuite);
- await verificationFail({credential, verifier});
+ 'proofConfig.cryptosuite is not set to bbs-2023, an error MUST ' +
+ 'be raised and SHOULD convey an error type of ' +
+ 'PROOF_GENERATION_ERROR.', async function() {
+ this.test.link = 'https://w3c.github.io/vc-di-bbs/#:~:text=If%20proofConfig.type%20is%20not%20set%20to%20DataIntegrityProof%20and/or%20proofConfig.cryptosuite%20is%20not%20set%20to%20bbs%2D2023%2C%20an%20error%20MUST%20be%20raised%20and%20SHOULD%20convey%20an%20error%20type%20of%20PROOF_GENERATION_ERROR.';
+ await verificationFail({
+ credential: cloneTestVector(
+ disclosed?.invalid?.proofTypeAndCryptosuite),
+ verifier
+ });
+ await verificationFail({
+ credential: cloneTestVector(
+ disclosed?.invalid?.cryptosuite),
+ verifier
+ });
+ await verificationFail({
+ credential: cloneTestVector(
+ disclosed?.invalid?.proofType),
+ verifier
+ });
  });
  it('Whenever this algorithm (base proof) encodes strings, it MUST ' +
  'use UTF-8 encoding.', async function() {