Update package name and legacy terms. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change `StatusList2021` to `BitstringStatusList`, - Change `StatusList2021Credential` to `BitstringStatusListCredential`. - Change `StatusList2021Entry` to `BitstringStatusListEntry`.
PatStLouis
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Would it be useful too add this name change to the changelog?
## 1.1.1 - 2024-06-11
### Changed
- Updated `status-list-2021-test-suite` package name to
`vc-bitstring-status-list-test-suite`.
There was a problem hiding this comment.
What should we do about the https://w3id.org/vc/status-list/2021/v1 context url? Without upgrade to data model v2, what context is to be used with BitstringStatusList?
|
@JSAssassin any blockers to mark this PR as ready for review? |
aljones15
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Approving provided that @PatStLouis is happy with the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status-list-2021-test-suitetovc-bitstring-status-list-test-suiteStatusList2021toBitstringStatusList,StatusList2021CredentialtoBitstringStatusListCredential.StatusList2021EntrytoBitstringStatusListEntry.StatusList2021toBitstringStatusList.NOTE: This has not been tested. We do not want to merge this until we have implementations that uses the latest contexts. Leaving the PR as a draft for now. Also tag in vc-test-suite-implementations in w3c-ccg org will have to be updated when this PR is merged. There is a draft PR for that there.)
TODO: