Remove more definitions of MutationEvent and friends #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
garykac
approved these changes
Sep 6, 2024
|
Argh! I thought this PR had already been merged before I deleted the obsolete files. Also, note that the README file has a "To make edits to the spec" section that identifies the files that need to be updated. |
No problem. I believe I just rebased on top of all of the deletions, but could you take a look?
Right, I saw that, but it sounds from the wording like there shouldn't be target files (e.g. TR.html) included in the committed tree. And locally running build.py didn't seem to update any of them. So I was confused. |
github-actions bot
added a commit
that referenced
this pull request
Sep 7, 2024
SHA: 02207f8 Reason: push, by garykac Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #381 for the first part of this cleanup.
I really don't understand how this repo is structured, it seems like tons of generated files are checked in, and aren't actually built by the
build.py. I ended up just manually deleting mutation events from all the places, hopefully correctly.The following tasks have been completed:
web-platform-tests/wpt#47727
Implementation commitment: