feat[venom]: fix offset pass #4248
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harkal
reviewed
Sep 24, 2024
| and isinstance(inst.operands[0], IRLiteral) | ||
| and isinstance(inst.operands[1], IRLabel) | ||
| ): | ||
| if not inst.opcode == "add": |
There was a problem hiding this comment.
Suggested change
| if not inst.opcode == "add": | |
| if inst.opcode != "add": |
There was a problem hiding this comment.
no wonder it was not working!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4248 +/- ##
===========================================
- Coverage 89.39% 51.35% -38.05%
===========================================
Files 112 112
Lines 15923 15928 +5
Branches 2693 2695 +2
===========================================
- Hits 14235 8180 -6055
- Misses 1192 7120 +5928
- Partials 496 628 +132 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix offset pass in the case that the arguments are swapped
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture