Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore vk.xml and spirv.core.grammar.json from editor search results #2590

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

marc0246
Copy link
Contributor

Having these files be searched when one is doing a project-wide search is rather counter-productive. This fixes that for any editor that uses ripgrep e.g. vscode, Helix and Neovim with the Telescope plugin.

@Rua
Copy link
Contributor

Rua commented Oct 22, 2024

Is there a way to un-ignore those files, if I do want to search in them?

@marc0246
Copy link
Contributor Author

Yes, open it and search.

@Rua
Copy link
Contributor

Rua commented Oct 22, 2024

I do hope that this won't confuse and surprise people who edit/contribute to the codebase, but we'll see.

@Rua Rua merged commit 54dafb7 into vulkano-rs:master Oct 22, 2024
6 checks passed
@marc0246 marc0246 deleted the editor-search-ignore branch October 22, 2024 15:17
@marc0246
Copy link
Contributor Author

The few times I wanted to search in one of these files was because I was working specifically on the autogen. I don't see any reason for including these files in project-wide search. You want to search for the occurance of some code pattern most commonly, and vk.xml specifically has been getting in my way so many times that it's frustrating. And always with hundreds of results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants