Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WebSocket debugger tunnel #1200

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Remove WebSocket debugger tunnel #1200

merged 2 commits into from
Oct 30, 2023

Conversation

arturpimentel
Copy link
Collaborator

What is the purpose of this pull request?

Change toolbelt default behavior so it does not automatically create debug tunnels using websocket

What problem is this solving?

WebSocket support is currently blocking an important infrastructure
migration in VTEX IO. We'll remove this feature so that we can
move on with it.

How should this be manually tested?

  1. yarn watch;
  2. vtex-test link {{app}} -> should link an app without creating a debug tunnel;

Screenshots or example usage

Before:
image
After:
image

Types of changes

  • Refactor (non-breaking change that only makes the code better)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Chores checklist

  • Update CHANGELOG.md

@arturpimentel arturpimentel self-assigned this Oct 25, 2023
Copy link
Contributor

@filafb filafb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This one was blocking one the PR checks
@arturpimentel arturpimentel merged commit 5e29109 into main Oct 30, 2023
4 checks passed
@arturpimentel arturpimentel deleted the remove/debugger branch October 30, 2023 13:23
@arturpimentel arturpimentel mentioned this pull request Oct 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants