Skip to content

Commit

Permalink
Update node version (#1231)
Browse files Browse the repository at this point in the history
* Run prettier to pass failing test

* Update oclif config to use node 20
Ref: https://oclif.io/blog/2019/10/31/oclif-node-updates/\#packaged-node-version

* Use node 20 in the cicd pipelines

* Bump version

* Update changelog

* Bump version and update changelog
  • Loading branch information
filafb authored Aug 1, 2024
1 parent 6af50b2 commit 3212e13
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 17 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 20
- run: yarn install --ignore-scripts
- run: yarn run ci:prettier-check
- run: yarn run lint:node
Expand All @@ -25,7 +25,7 @@ jobs:
strategy:
fail-fast: true
matrix:
node-version: [12]
node-version: [20]
os: [ubuntu-latest, windows-latest, macOS-latest]

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-prerelease-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 20
registry-url: https://registry.npmjs.org/
- run: yarn install --ignore-scripts
- run: yarn build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-stable-aws.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 20
registry-url: https://registry.npmjs.org/
- name: 'Install makensis (apt)'
run: sudo apt update && sudo apt install -y nsis nsis-pluginapi
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-stable-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 20
registry-url: https://registry.npmjs.org/
- name: Deploy on NPM
run: |
Expand Down
11 changes: 8 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,21 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [4.1.0] - 2024-08-01

### Changed
- Pack toolbelt using nodejs 20
- Allow specific builder config to override the common config for pinned dependencies

## [4.0.5] - 2024-03-25

### Fixed

- handle OPTIONS request for CORS
- update `publish-stable-aws` pipeline

### Changed
- Allow specific builder config to override the common config for pinned dependencies

## [4.0.4] - 2023-11-03

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vtex",
"version": "4.0.5",
"version": "4.1.0",
"description": "The platform for e-commerce apps",
"bin": "bin/run",
"main": "lib/api/index.js",
Expand Down Expand Up @@ -178,7 +178,7 @@
],
"update": {
"node": {
"version": "12.12.0"
"version": "20.16.0"
},
"s3": {
"bucket": "vtex-toolbelt-test"
Expand Down
6 changes: 3 additions & 3 deletions src/modules/apps/install.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function handleAccountNotSponsoredByVendorError(app: string) {
}

const prepareInstall = async (appsList: string[], force: boolean): Promise<void> => {
let exitWithError = false;
let exitWithError = false

for (const app of appsList) {
ManifestValidator.validateApp(app)
Expand Down Expand Up @@ -81,7 +81,7 @@ const prepareInstall = async (appsList: string[], force: boolean): Promise<void>
}
log.info(`Installed app ${chalk.green(app)} successfully`)
} catch (e) {
exitWithError = true;
exitWithError = true
if (isNotFoundError(e)) {
log.warn(
`Billing app not found in current workspace. Please install it with ${chalk.green(
Expand Down Expand Up @@ -111,7 +111,7 @@ const prepareInstall = async (appsList: string[], force: boolean): Promise<void>
}
}

if (exitWithError) process.exit(1);
if (exitWithError) process.exit(1)
}

export default async (optionalApps: string[], options) => {
Expand Down
4 changes: 2 additions & 2 deletions src/modules/apps/publish.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ const publisher = (workspace = 'master') => {
)
}
} catch (e) {
log.error(`Failed to publish ${appId}`);
process.exit(1);
log.error(`Failed to publish ${appId}`)
process.exit(1)
}

await returnToPreviousAccount({ previousAccount, previousWorkspace })
Expand Down
4 changes: 2 additions & 2 deletions src/modules/apps/unlink.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Make sure you typed the right app vendor, name and version.`)
log.error(e.response.data.message)
}
}
process.exit(1);
process.exit(1)
}
}

Expand All @@ -41,7 +41,7 @@ const unlinkAllApps = async (): Promise<void> => {
if (e?.response?.data?.message) {
log.error(e.response.data.message)
}
process.exit(1);
process.exit(1)
}
}

Expand Down

0 comments on commit 3212e13

Please sign in to comment.