-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/Linter and prettier #202
Open
GabrielBarross
wants to merge
7
commits into
master
Choose a base branch
from
hotfix/lint-and-prettier
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielBarross
requested review from
wagnerlduarte and
rerissondaniel
and removed request for
a team
October 1, 2024 12:24
wagnerlduarte
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
apps/vtex-my-subscriptions-3/react/components/DetailsPage/History/HistoryItem.tsx
Show resolved
Hide resolved
apps/vtex-my-subscriptions-3/react/components/DetailsPage/History/HistoryList.tsx
Outdated
Show resolved
Hide resolved
rerissondaniel
approved these changes
Oct 8, 2024
…ory/HistoryList.tsx Co-authored-by: Rerisson Daniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fix eslint errors
https://vtex-dev.atlassian.net/browse/OMS-4310
What problem is this solving?
Improve the development experience
How should this be manually tested?
run yarn verify and check that it returns no errors
Screenshots or example usage
Types of changes