Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NaN when string is inputed on quantity input #2534

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EmanuelRamos115
Copy link
Contributor

@EmanuelRamos115 EmanuelRamos115 commented Oct 31, 2024

What's the purpose of this pull request?

Resolves the bug that when typing letters in the quantity input a "NaN" error appears

How it works?

I validated the function to change the input to remove any non-numeric value

How to test it?

Go to the product page and try to enter a value other than a number in the quantity input

https://newswarovskiargentina-cm2bukmqh008u9fpvz46jty9h-rarbnwb8d.b.vtex.app/5662923-conjunto-stilla-tallas-mixtas-multicolor-bano-tono-oro-rosa-11436/p

Checklist

PR Title and Commit Messages

  • PR title and commit messages follow the Conventional Commits specification
    • Available prefixes: feat, fix, chore, docs, style, refactor and test

PR Description

  • Added a label according to the PR goal - breaking change, bug, contributing, performance, documentation..

Dependencies

  • Committed the yarn.lock file when there were changes to the packages

@EmanuelRamos115 EmanuelRamos115 requested a review from a team as a code owner October 31, 2024 20:23
@EmanuelRamos115 EmanuelRamos115 requested review from hellofanny and eduardoformiga and removed request for a team October 31, 2024 20:23
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:28pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants