-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: adds LazyLoadingSection component - perf #2521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
hellofanny
changed the title
Feat/lazy loading section sfs 1508
Feat: adds LazyLoadingSection component - perf
Oct 24, 2024
hellofanny
requested review from
emersonlaurentino and
renatamottam
and removed request for
a team
October 24, 2024 13:47
pedromtec
reviewed
Oct 24, 2024
pedromtec
approved these changes
Oct 24, 2024
Do you test the web vitals score? |
Co-authored-by: Pedro Soares <[email protected]>
lucasfp13
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Adds
LazyLoadingSection
component, it will be responsible for lazy loading Sections that are out of the viewport.We will be implementing this in the
RenderSectionsBase
as part of our upcoming tasks. This component is not being applied in isolation due to concerns about increased Cumulative Layout Shift (CLS).How to test it?
LazyLoadingSection
is temporary applied or locally add it inRenderSectionsBase
component.Footer
, you won't find it until you scroll the page until theNewsletter
sectiontest-lazyloadingsection.mov
Starters Deploy Preview
vtex-sites/starter.store#586
References
#2404