Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DNK postal code rules #618

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix DNK postal code rules #618

merged 1 commit into from
Oct 9, 2024

Conversation

GeorgeLimaDev
Copy link
Contributor

@GeorgeLimaDev GeorgeLimaDev commented Oct 7, 2024 •
edited by jira bot
Loading

What is the purpose of this pull request?

It relates to the task LOC-16864. It fixes the behavior in the field postalCode for DNK.

How should this be manually tested?

Accepted values now should be only 4 digits-long strings.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd VTEX IO CI/CD
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 7, 2024 •
edited by GeorgeLimaDev
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@GeorgeLimaDev GeorgeLimaDev marked this pull request as ready for review October 7, 2024 14:01
@GeorgeLimaDev GeorgeLimaDev requested a review from a team as a code owner October 7, 2024 14:01
@GeorgeLimaDev GeorgeLimaDev merged commit a6d96a4 into main Oct 9, 2024
52 of 54 checks passed
@GeorgeLimaDev GeorgeLimaDev deleted the loc/16864-main branch October 9, 2024 20:55
@GeorgeLimaDev GeorgeLimaDev mentioned this pull request Oct 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersontuc jeffersontuc jeffersontuc approved these changes

@evertonstrack evertonstrack Awaiting requested review from evertonstrack

@kaio-donadelli kaio-donadelli Awaiting requested review from kaio-donadelli

Assignees
No one assigned
Labels
Localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgeLimaDev @jeffersontuc