Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Required className #612

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Add: Required className #612

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c268402
update StyleguideInput
beatrizmaselli Sep 19, 2024
6f8e751
update valid const
beatrizmaselli Sep 23, 2024
d6af858
add space to required field
beatrizmaselli Sep 23, 2024
e034d37
Merge branch '4.x' into Add/required-className
beatrizmaselli Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Added
- "...-required" classNames for the StyleguideInput component.

## [4.25.2] - 2024-09-18

### Added
Expand Down
12 changes: 4 additions & 8 deletions react/inputs/StyleguideInput/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class StyleguideInput extends Component {

const disabled = !!address[field.name].disabled

const valid = address[field.name].valid === false ? false : true
const valid = address[field.name].valid !== false

const loading =
loadingProp != null ? loadingProp : address[field.name].loading
Expand Down Expand Up @@ -140,15 +140,11 @@ class StyleguideInput extends Component {
field.name
} vtex-address-form__field--${field.size || 'xlarge'} ${
field.hidden ? 'dn' : ''
} ${
disabled ? 'vtex-address-form__field-disabled' : ''
} ${
} ${disabled ? 'vtex-address-form__field-disabled' : ''} ${
!valid ? 'vtex-address-form__field-invalid' : ''
} ${
!address[field.name].value ? 'vtex-address-form__field-empty' : ''
} ${
} ${!address[field.name].value ? 'vtex-address-form__field-empty' : ''} ${
this.state.isFocused ? 'vtex-address-form__field-focused' : ''
}`
} ${field.required ? 'vtex-address-form__field-required' : ''}`

if (field.name === 'postalCode') {
return (
Expand Down
Loading