Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change field prop for state in GBR #547

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Change field prop for state in GBR #547

merged 3 commits into from
Apr 2, 2024

Conversation

lucvysk
Copy link
Contributor

@lucvysk lucvysk commented Nov 8, 2023

What is the purpose of this pull request?

Fix the state selection for england

What problem is this solving?

Geolocation from google change and currently administrative_area_level_1 for GBR now returns the country instead of the state. The first selection was added.

image

How should this be manually tested?

app linked:
image

currently:
image

Types of changes

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@lucvysk lucvysk requested a review from a team as a code owner November 8, 2023 21:49
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 8, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@jeffersontuc
Copy link
Contributor

jeffersontuc commented Mar 27, 2024

Thanks for the contribution! Could you update the CHANGELOG? 🙏🏽

@lucvysk
Copy link
Contributor Author

lucvysk commented Apr 1, 2024

Just did!

@jeffersontuc jeffersontuc merged commit a8aec8c into main Apr 2, 2024
49 of 54 checks passed
@jeffersontuc jeffersontuc deleted the fix/gbr branch April 2, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants