Vine patch 1 #533
Closed
Vine patch 1 #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating the way GAPI auto-filled address is displayed at checkout. Client needs the neighborhood to show.
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
It seems it was already implemented by another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
<added neighborhood to the GAPI-generated address at checkout.
What problem is this solving?
The suburb is mandatory in New Zealand. By adding it to the address format display, it solves a client request.
How should this be manually tested?
Clone the repo to VSCODE, login to localtest--vineoneline.myvtex.com, add the changes to the NZL.ts country file and change the manifest json app version, then link the app to the workspace. Proceed with placing an order and choose an address, for example 1020 .... (google maps auto-fill will do the rest). Notice the suburb is showing.
Client is live, do not attempt this on the master workspace please.
Screenshots or example usage
Types of changes