Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ECU postal code selection to use cities. #531

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Fix ECU postal code selection to use cities. #531

merged 2 commits into from
Sep 12, 2023

Conversation

kaio-donadelli
Copy link
Contributor

@kaio-donadelli kaio-donadelli commented Jul 14, 2023 •
edited by jira bot
Loading

What is the purpose of this pull request?

Show the city list during check-out in Ecuador stores to allow for more granular shipping settings. Tracked in task LOC-11656.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@kaio-donadelli kaio-donadelli requested a review from a team as a code owner July 14, 2023 18:12
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jul 14, 2023 •
edited by kaio-donadelli
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

vmarcosp
vmarcosp previously approved these changes Jul 17, 2023
View reviewed changes
sheilagomes
sheilagomes approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@sheilagomes sheilagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaio-donadelli kaio-donadelli merged commit 5685437 into main Sep 12, 2023
22 of 52 checks passed
@kaio-donadelli kaio-donadelli deleted the fix/ECU-city-postalcodes branch September 12, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheilagomes sheilagomes sheilagomes approved these changes

@vmarcosp vmarcosp vmarcosp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaio-donadelli @vmarcosp @sheilagomes