update badges and add tags to metadata #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
reviewed
Oct 24, 2017
| [](https://forge.puppet.com/puppet/corosync) | ||
| [](https://travis-ci.org/voxpupuli/puppet-corosync) | ||
| [](https://forge.puppet.com/approved) | ||
| [](https://bestpractices.coreinfrastructure.org/projects/533) |
There was a problem hiding this comment.
I can add it back, I didn't see it in our other ones, and thought we were trying to keep a standard set? Re-added.
Also the scores one doesn't seem to be working AFAICT - I get https://img.shields.io/puppetforge/f/puppet/corosync.svg 'score unknown' for this despite the forge having a score (same for mongodb)
There was a problem hiding this comment.
yes the CII badge is proving the quality of this repo. We should instead add it to other repositories.
|
@alexjfisher tests are passing now. the CII badge is added back. |
dhollinger
approved these changes
Oct 26, 2017
There was a problem hiding this comment.
Looks good to me, but I'd like @alexjfisher or @roidelapluie to review as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update badges in README based on other modules.
This might also help until the issues discussed in #32 are addressed?