Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdditionalProperties not being applied when value could be array #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dharanikumar-19
Copy link

@dharanikumar-19 dharanikumar-19 commented Aug 17, 2019

This fix should will resolve this issue #404

Given the following schema:

{ "type": [ "object", "null" ], "properties": { "a_string": { "type": "string" } }, "additionalProperties": false }
The sample data
object = { "a_string": "this property is allowed by the schema", "an_extra_string": "the schema does not allow this property" }

Previously it does not raise any error

After the fix
Following error will throw
JSON::Schema::ValidationError: The property '#/' contains additional properties ["an_array"] outside of the schema when none are allowed

@pboling
Copy link

pboling commented Feb 14, 2021

#423 (comment)

@bastelfreak
Copy link
Member

Hi @dharanikumar-19, thanks for this PR. Are you able to rebase and add tests for the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants