Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize PR template across repos. #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aekblad
Copy link
Contributor

@aekblad aekblad commented Oct 15, 2024

What changes are made in this PR?

Use the same PR template as all other Spyder repos.

Why are these changes needed?

We want our PR templates to be short and uniform.

@aekblad aekblad requested a review from a team as a code owner October 15, 2024 14:02
Copy link
Contributor

@cperlman cperlman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a public repository, do we actually want this template here?

@aekblad
Copy link
Contributor Author

aekblad commented Oct 16, 2024

this is a public repository, do we actually want this template here?

I don't know. I do think the current PR template is overkill though.

@zbleness
Copy link
Contributor

this is a public repository, do we actually want this template here?

Our internal template works here too imho. except for the functional safety check.

Copy link
Contributor

@zbleness zbleness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants