Windows psscan issue 591 - Fix offsets when --physical is used #1215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
This PR aims to resolve issue where @garanews found an issue with windows psscan when using the --physical flag.
The main issue is covered in my comment here: #591 (comment)
I would recommend reading the comments on the issue (#591) as @ikelos raised some other good points on other ways to resolve this problem. It may be that this approach is not the best.
Thanks!
🦊