Skip to content

Commit

Permalink
Merge pull request #461 from jorgemoralespou/local-cmd-group
Browse files Browse the repository at this point in the history
Changes in local and platform set of commands.
  • Loading branch information
GrahamDumpleton authored Jun 21, 2024
2 parents 84a48cb + 7b6516f commit cda8e8a
Show file tree
Hide file tree
Showing 41 changed files with 549 additions and 395 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ rebaseRules:
sources: [existing, new]
resourceMatchers:
- kindNamespaceNameMatcher: { kind: Secret, name: secrets-manager-token, namespace: educates }
- kindNamespaceNameMatcher: { kind: Secret, name: session-manager-token, namespace: educates }
- kindNamespaceNameMatcher: { kind: Secret, name: session-manager-token, namespace: educates }
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@ metadata:
annotations:
kapp.k14s.io/change-group: #@ "secrets.{}/service-accounts".format(data.values.operator.apiGroup)
#! Following currently needed for kapp on OpenShift.
kapp.k14s.io/create-strategy: fallback-on-update
kapp.k14s.io/update-strategy: skip
#! TODO: Bring kapp rebaseRules for Openshift service accounts
#! kapp.k14s.io/create-strategy: fallback-on-update
#! kapp.k14s.io/update-strategy: skip
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ metadata:
annotations:
kubernetes.io/service-account.name: "secrets-manager"
kapp.k14s.io/change-rule: #@ "upsert after upserting secrets.{}/service-accounts".format(data.values.operator.apiGroup)
kapp.k14s.io/update-strategy: skip
#! kapp.k14s.io/update-strategy: skip
type: kubernetes.io/service-account-token
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ metadata:
annotations:
kapp.k14s.io/change-group: #@ "training.{}/service-accounts".format(data.values.operator.apiGroup)
#! Following currently needed for kapp on OpenShift.
kapp.k14s.io/create-strategy: fallback-on-update
kapp.k14s.io/update-strategy: skip
#! TODO: Bring kapp rebaseRules for Openshift service accounts
#! kapp.k14s.io/create-strategy: fallback-on-update
#! kapp.k14s.io/update-strategy: skip

---
apiVersion: v1
Expand All @@ -20,5 +21,6 @@ metadata:
namespace: #@ data.values.operator.namespace
annotations:
#! Following currently needed for kapp on OpenShift.
kapp.k14s.io/create-strategy: fallback-on-update
kapp.k14s.io/update-strategy: skip
#! TODO: Bring kapp rebaseRules for Openshift service accounts
#! kapp.k14s.io/create-strategy: fallback-on-update
#! kapp.k14s.io/update-strategy: skip
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ metadata:
annotations:
kubernetes.io/service-account.name: "session-manager"
kapp.k14s.io/change-rule: #@ "upsert after upserting training.{}/service-accounts".format(data.values.operator.apiGroup)
kapp.k14s.io/update-strategy: skip
#! kapp.k14s.io/update-strategy: skip
type: kubernetes.io/service-account-token
2 changes: 1 addition & 1 deletion carvel-packages/installer/bundle/config/ytt/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@
--- #@ template.replace(overlay.apply(library.get(packagePath).with_data_values(packageValues).eval(), addKappAnnotations(name, overlayedValues, orderedPackagesList)))
#@ end
#@ end
--- #@ template.replace(overlay.apply(library.get("config").with_data_values(overlayedValues).eval()))
--- #@ template.replace(overlay.apply(library.get("config").with_data_values(overlayedValues).eval(), addKappAnnotations("educates", overlayedValues, orderedPackagesList)))
#@ end
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ metadata:
#@overlay/match missing_ok=True
educates.dev/infra-provider: #@ data.values.clusterInfrastructure.provider
#@overlay/match missing_ok=True
kapp.k14s.io/disable-original: ""
#@overlay/match missing_ok=True
kapp.k14s.io/change-group.package: #@ "educates-installer/{}".format(packageName)
#@overlay/match missing_ok=True
kapp.k14s.io/change-group.global: #@ "educates-installer"
Expand Down
7 changes: 1 addition & 6 deletions client-programs/pkg/cmd/admin_cmd_group.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
func (p *ProjectInfo) NewAdminCmdGroup() *cobra.Command {
var c = &cobra.Command{
Use: "admin",
Short: "Tools for installing Educates on Kubernetes",
Short: "Tools for administering Educates on Kubernetes",
}

// Use a command group as it allows us to dictate the order in which they
Expand All @@ -19,12 +19,7 @@ func (p *ProjectInfo) NewAdminCmdGroup() *cobra.Command {
{
Message: "Available Commands:",
Commands: []*cobra.Command{
p.NewAdminClusterCmdGroup(),
p.NewAdminPlatformCmdGroup(),
p.NewAdminConfigCmdGroup(),
p.NewAdminSecretsCmdGroup(),
p.NewAdminRegistryCmdGroup(),
p.NewAdminResolverCmdGroup(),
p.NewAdminDiagnosticsCmdGroup(),
},
},
Expand Down
90 changes: 0 additions & 90 deletions client-programs/pkg/cmd/admin_config_view_cmd.go

This file was deleted.

1 change: 1 addition & 0 deletions client-programs/pkg/cmd/admin_platform_cmd_group.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ func (p *ProjectInfo) NewAdminPlatformCmdGroup() *cobra.Command {
Commands: []*cobra.Command{
p.NewAdminPlatformDeployCmd(),
p.NewAdminPlatformDeleteCmd(),
p.NewAdminPlatformValuesCmd(),
},
},
}
Expand Down
Loading

0 comments on commit cda8e8a

Please sign in to comment.