Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run_me.sh to work on macOS #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

simonw
Copy link

@simonw simonw commented May 10, 2023

I got errors running this script on macOS, because the bash version there didn't support the [[ ! -v WASI_SDK_PATH ]] syntax and the date version did not support date --iso-8601=ns.

@vmwclabot
Copy link

@simonw, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@simonw
Copy link
Author

simonw commented May 10, 2023

The CLA web flow there appears to be broken:

cla

@assambar
Copy link
Contributor

Thanks @simonw for contributing this!

We've reported the CLA portal failure to the responsible team. We will ping you once we have an update on that.

@Angelmmiguel
Copy link
Contributor

Hello @simonw,

Thank you for your contribution! Our internal team mentioned it was a transient issue with the GitHub authentication. Please, could you retry it in a new browser window? It should work now.

Copy link
Contributor

@assambar assambar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @simonw!

@ereslibre
Copy link
Contributor

@simonw Please, can you retry the CLA workflow? Sorry for the inconvenience.

@vmwclabot
Copy link

@simonw, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link

@simonw, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide more address detail - Minimum required is Country, State, Town/City.

@ereslibre
Copy link
Contributor

Hello @simonw,

Sorry for the long time to reply and thank you for your contribution. After some long discussions, this project is currently in the process of being archived. However, the development of this project will continue as an independent community fork present at https://github.com/webassemblylabs/webassembly-language-runtimes.

We would be grateful if you could recreate your contribution under that fork and we will work on applying it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants