feat: use custom error types in internal and external crates #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereslibre
force-pushed
the
error-types
branch
3 times, most recently
from
2a40dec
to
4a2e87b
Compare
|
Marking as ready for review! |
ereslibre
force-pushed
the
error-types
branch
2 times, most recently
from
8da9884
to
bb4e3e1
Compare
Angelmmiguel
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
The PR is really great! It simplifies the way you can programmatically manage errors on Wasm Workers Server. I added a few comments, but most of them are just consolidating the names between different crates:
CouldNot -> Cannot
ErrorXXX -> XXXError
I'm gonna approve it in advance, but please take a look at the suggestions before merging it :)
Co-authored-by: Ángel M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #181, although that PR is not strictly necessary for this one.
Fixes: #73