Fix idol of the moon bonus damage #2802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Changes how Idol of the moon bonus damage is calculated.
Note: I can't find any evidence that this idol added 17% as stated by the item tooltip - more info linked further below.
Before this PR:
After this PR:
For rank 10 moonfire this equals to:
Proof
Patch 1.12.1 Known Issues
Spell damage awarded from Idol of the Moon is inconsistent with it's tooltip.
Posted on Druid classic discord: https://discord.com/channels/253205420225724416/253206622522834945/743124572475490316
Image represents Rank 10 moonfire direct damage. From my interpretation that looks like 4-5 damage difference. No raw data available.
From wowhead comments:
(note: edited for easier readability)
This equals an increase by 4.325 damage - since the tests mention crits, we can deduce that this is the direct damage part.
Tick damage.
Counterproof
There are also comments on druid classic discord that mention its 20 + 20 damage. 20 direct damage and 4 x 5 dot damage. None of those comments are backed up by evidence, and seems to be a constant copy/pasta response based on initial testing. Since the direct damage portion of the spell varies by 36 damage - tests with low samplesize could be missleading.
Mentions of a GM talking about how this spell could negate other bonusses. I can't deduce any math formula that would negate the "Improve Moonfire" talents and give the expected results.
It's not possible to test this ERA PTR, since Blizzard changed the item to its TBC version which adds +33 damage.
Issues
How2Test
Todo / Checklist