Fix idol of the moon bonus damage

[Gamemechanicwow]

🍰 Pullrequest

Changes how Idol of the moon bonus damage is calculated.
Note: I can't find any evidence that this idol added 17% as stated by the item tooltip - more info linked further below.

Before this PR:

• add +17 damage

After this PR:

• add 17/8 % to direct basedamage part of moonfire
• add 17 % to total tick basedamage

For rank 10 moonfire this equals to:

• ~4.5 damage per tick
• 4.14375 to 4.485 damage to direct damage. That averages to 4.314375

Proof

Patch 1.12.1 Known Issues

Spell damage awarded from Idol of the Moon is inconsistent with it's tooltip.

Posted on Druid classic discord: https://discord.com/channels/253205420225724416/253206622522834945/743124572475490316

Image represents Rank 10 moonfire direct damage. From my interpretation that looks like 4-5 damage difference. No raw data available.

From wowhead comments:

(note: edited for easier readability)
This equals an increase by 4.325 damage - since the tests mention crits, we can deduce that this is the direct damage part.

Tick damage.

Counterproof

There are also comments on druid classic discord that mention its 20 + 20 damage. 20 direct damage and 4 x 5 dot damage. None of those comments are backed up by evidence, and seems to be a constant copy/pasta response based on initial testing. Since the direct damage portion of the spell varies by 36 damage - tests with low samplesize could be missleading.

Mentions of a GM talking about how this spell could negate other bonusses. I can't deduce any math formula that would negate the "Improve Moonfire" talents and give the expected results.

It's not possible to test this ERA PTR, since Blizzard changed the item to its TBC version which adds +33 damage.

Issues

• None

How2Test

• None

Todo / Checklist

• Tick damage is still 0.5 lower per tick, than what has been reported on the sources I could find. But it's so close to 17% divided by ticks, that I decided to stick with that.