Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Fix patch for AQ gate. #2701

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Conversation

Daribon
Copy link
Contributor

@Daribon Daribon commented Jul 9, 2024

🍰 Pullrequest

This PR corrects the following:

  • Use correct AQ gate objects for post 1.9.
  • Correct coordinates for pre 1.9 AQ gate objects.
  • Fixes custom gameobject_template entries AQ gate objects pre 1.9.
  • Use rotation from sniff for old gong.

Proof

  • 1.8.0 sniff for old AQ gate.
  • Guessed position for old AQ gate rune and root, based on screenshots, since it was never sniffed in 1.8.0.

Vanilla unknown date pre 1.9:
scarab_wall
Patch 1.8.1:
WoWScrnShot_121005_112707
Unknown date pre patch 1.3, outside of server view distance of root and runes:
04

Old AQ gate in vanilla pre patch 1.9:
nomacs_qBb9dtYhip
Old AQ gate in vmangos after this PR applied:
WoW_U7msC7yY0x

AQ gate post 1.9 in vmangos:
WoW_iNVoF0vr4M

AQ gate 1.9 vanilla:
WoWScrnShot_022306_184652

Issues

  • None

How2Test

  • None

Todo / Checklist

  • Add positions for AQ rune and roots post 1.11. Unsure why blizz changed it.
  • Fix silithus.cpp

@0blu 0blu added the SQL A issue / PR which references SQL code label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL A issue / PR which references SQL code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants