Sweeping strikes like on classic #2650
Open
+40
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0blu
reviewed
Jun 30, 2024
| @@ -371,7 +371,11 @@ SpellProcEventTriggerCheck Unit::IsTriggeredAtSpellProcEvent(Unit* pVictim, Spel | |||
| return SPELL_PROC_TRIGGER_OK; | |||
| } | |||
| #endif | |||
|
|
|||
| // Never proc for Rend. | |||
| if (spellProto->Id == 12292) | |||
There was a problem hiding this comment.
I think the indentation look wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Title ^
Proof
Issues and videos from classic in this discussion (#2647)
How2Test
create warrior
.level 59
.cheat power on
.cheat cooldown on
.npc summon 17685 x4
.learn 12292
.learn 1680
.learn 11574
.learn 20569
Todo / Checklist
-- Still not perfect. On classic fully dodged/parried whirlwind still procs SS. (doesnt make sense but thats how it is there)
-- changing this line in UnitAuraProcHandler
if (!target)
return SPELL_AURA_PROC_FAILED;
to SPELL_AURA_PROC_OK enables stacks to burn while solo target. It might allow to get accidentaly pvp flagged, although i dont think it was preventing that from happening before anyway.