Fix HFTrainer overloads #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
kylesayrs
force-pushed
the
kylesayrs/fix-trainer-function-contracts
branch
from
9d51505
to
9a7711e
Compare
mgoin
previously approved these changes
Oct 27, 2024
rahul-tuli
previously approved these changes
Oct 27, 2024
dsikka
previously approved these changes
Oct 28, 2024
rahul-tuli
previously approved these changes
Oct 28, 2024
|
Should we add *args, **kwargs and pass them to the super functions, to protect against future changes like this? |
mgoin
previously approved these changes
Oct 28, 2024
|
@rahul-tuli Since both functions require some information from the inputs, I think I'd prefer to expose all the arguments. There are tradeoffs either way w.r.t. erroring when arguments change |
kylesayrs
dismissed stale reviews from mgoin, rahul-tuli, and dsikka
via
b6b54fb
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
kylesayrs
force-pushed
the
kylesayrs/fix-trainer-function-contracts
branch
from
b6b54fb
to
84be172
Compare
dsikka
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
tests/llmcompressor/transformers/finetune/test_finetune_no_recipe_custom_dataset.pyBackground
Changes
Testing
tests/llmcompressor/transformers/finetune/test_finetune_no_recipe_custom_dataset.pynow passes