Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Modify Params Context #855

Closed
wants to merge 3 commits into from
Closed

[WIP] Modify Params Context #855

wants to merge 3 commits into from

Conversation

kylesayrs
Copy link
Collaborator

Purpose

  • Provide a context within which parameters belonging to FSDP or accelerate-offloaded models can be safely modfied
  • Note that the parameters must be modified in-place through in-place operations like copy_ rather than assignment or assigning to the tensor data directly

@kylesayrs kylesayrs marked this pull request as draft October 19, 2024 20:12
@vllm-project vllm-project deleted a comment from github-actions bot Oct 20, 2024
@kylesayrs
Copy link
Collaborator Author

Closing, can be reopened when better FSDP support is the priority

@kylesayrs kylesayrs closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylesayrs