-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observer Restructure]: Add Observers; Add calibration
and frozen
steps to QuantizationModifier
#837
Conversation
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
calibration
, and frozen
steps to lifecycle
calibration
, and frozen
steps to lifecyclecalibration
, and frozen
steps to QuantizationModifier
calibration
, and frozen
steps to QuantizationModifier
calibration
and frozen
steps to QuantizationModifier
Can you confirm you're using the most recent commit for both? I do not get this error. And in general you should not as the scales are defined under |
Co-authored-by: Kyle Sayers <[email protected]>
Co-authored-by: Kyle Sayers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the new structure, Great work!
Left a few nits, would recommend revisiting the docstrings and updating them for consistency:
-> Start docstrings with a Capital Letter
-> Include param info in :params
over just writing a description in the main docstring
Otherwise no big red flags! Good tests as well.
SUMMARY:
QuantizationModifier
. All required calibration lifecycle steps can now be found incalibration.py
calibration
, and applyingfrozen
steps from lifecycle neuralmagic/compressed-tensors#189QuantizationModifier
Testing: