Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patroni pre-checks: check etcd cluster accessible #476

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lavr
Copy link
Contributor

@lavr lavr commented Sep 27, 2023

I suggest checking the network availability of the etcd cluster before adding nodes to the Patroni cluster. If etcd is unavailable for some reason, don't even attempt to add the node.

I created the role patroni/pre-checks for this purpose and added it to the playbooks deploy_pgcluster.yml and add_pgnode.yml.

I considered adding this checks to other playbooks but decided it might hinder the administrator from updating the cluster in some situations, which could be unsafe.

@vitabaks
Copy link
Owner

vitabaks commented Sep 27, 2023

@lavr Thanks!

Maybe it 's worth move this task to an already existing pre-checks role?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants