fix #1760 - the phenomenon that data is not properly initialize #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify to call "setImageData3D" method even if "2d-array" in addition to "3d"
|
The immediate phenomenon has been resolved, but the 'setImageData3D' method has not yet been added to the test case. |
ibgreen
approved these changes
Jul 13, 2023
|
Ideally we should add test cases, but happy to land this for now. |
ibgreen
deleted the
1760-if-dimension-is-2d-array-webgltexture-will-not-be-initialized-correctly
branch
Seungup
restored the
1760-if-dimension-is-2d-array-webgltexture-will-not-be-initialized-correctly
branch
Seungup
deleted the
1760-if-dimension-is-2d-array-webgltexture-will-not-be-initialized-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify to call "setImageData3D" method even if "2d-array" in addition to "3d"
For #1760
Background
Change List