Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clap-migration: Moving from StructOpt to Clap #52

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

larrydewey
Copy link
Contributor

As StructOpt is deprecated and no longer maintained, we need to switch to clap.

@larrydewey larrydewey force-pushed the clap-migration branch 2 times, most recently from 285836c to 1fb975b Compare April 23, 2024 21:08
@larrydewey larrydewey linked an issue Apr 23, 2024 that may be closed by this pull request
@larrydewey larrydewey added the enhancement New feature or request label Apr 23, 2024
Copy link
Member

@DGonzalezVillal DGonzalezVillal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made some changes where the value names didn't seem to match what users are supposed to provide. If they were left like that for some reason, just let me know. Functionality wise, it looks good to me.

src/fetch.rs Outdated Show resolved Hide resolved
src/fetch.rs Outdated Show resolved Hide resolved
src/key.rs Outdated Show resolved Hide resolved
src/key.rs Outdated Show resolved Hide resolved
src/key.rs Outdated Show resolved Hide resolved
src/report.rs Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
As StructOpt is deprecated and no longer
maintained, we need to switch to clap.

Signed-off-by: Larry Dewey <[email protected]>
Copy link
Member

@DGonzalezVillal DGonzalezVillal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DGonzalezVillal DGonzalezVillal merged commit c47fa28 into virtee:main Apr 24, 2024
10 checks passed
@larrydewey larrydewey deleted the clap-migration branch April 24, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from deprecated StructOpt to Clap
4 participants