Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zone-update function. #86

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Added zone-update function. #86

merged 2 commits into from
Oct 15, 2020

Conversation

carlism
Copy link
Contributor

@carlism carlism commented Oct 12, 2020

Description of the Change

Added the zone-update command as per the request to accept a json representing the entire zone.
Tested this by requesting a previously created zone's json and changed the email address and submitted it back to zone-update.

Why Should This Be In The Package?

It adds the zone-update function addressing an open issue.

Benefits

Zone's may be updated using the cli

Possible Drawbacks

It requires you post a complete json. There's no facility for updating individual fields on a one off basis.

Verification Process

A successful response was received from the API and I confirmed that the record changed.

Applicable Issues (Optional)

Issue #46

Copy link

@pauljamescleary pauljamescleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlism !

@carlism carlism changed the title Added zone-update function. To address issue #46. Added zone-update function. Oct 13, 2020
Copy link

@pauljamescleary pauljamescleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mdb mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlism !

@mdb mdb merged commit e2ab329 into vinyldns:master Oct 15, 2020
@mdb mdb mentioned this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants