-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage report and add tests #3
Conversation
st.Expect(t, err, nil) | ||
st.Expect(t, str, bodyBytes) | ||
|
||
body = ioutil.NopCloser(&errorReader{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the error handling test should be splitted in a different test. @h2non what's the best practice in Go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better isolated,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'll change it then. Also do you have preference for multi-commits vs squashed commits in PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular preferences on that, but for me doing more commits should not be punished.
Changes Unknown when pulling 943eb2b on groyoh:add_tests into * on vinci-proxy:master*. |
@h2non I updated the tests to isolate the error cases. |
Changes Unknown when pulling 8ee6747 on groyoh:add_tests into * on vinci-proxy:master*. |
The test checks that when ReadBytes fails its error is returned.
The test checks that when Decode fails its error is returned.
I added a few more tests in the meantime. When I'm done with the tests, I'll start working on #4. |
Changes Unknown when pulling 7fda371 on groyoh:add_tests into * on vinci-proxy:master*. |
Changes Unknown when pulling 39c4bc9 on groyoh:add_tests into * on vinci-proxy:master*. |
Fix coverall test report by removing the token from the
.travis.yml
file. 3 tests were also added. I'll provide a few more tests in upcoming PRs.