Fix coverage report and add tests #3
Conversation
| st.Expect(t, err, nil) | ||
| st.Expect(t, str, bodyBytes) | ||
|
|
||
| body = ioutil.NopCloser(&errorReader{}) |
There was a problem hiding this comment.
I'm not sure if the error handling test should be splitted in a different test. @h2non what's the best practice in Go?
There was a problem hiding this comment.
Alright, I'll change it then. Also do you have preference for multi-commits vs squashed commits in PRs?
There was a problem hiding this comment.
No particular preferences on that, but for me doing more commits should not be punished.
|
Changes Unknown when pulling 943eb2b on groyoh:add_tests into * on vinci-proxy:master*. |
|
@h2non I updated the tests to isolate the error cases. |
|
Changes Unknown when pulling 8ee6747 on groyoh:add_tests into * on vinci-proxy:master*. |
The test checks that when ReadBytes fails its error is returned.
The test checks that when Decode fails its error is returned.
|
I added a few more tests in the meantime. When I'm done with the tests, I'll start working on #4. |
|
Changes Unknown when pulling 7fda371 on groyoh:add_tests into * on vinci-proxy:master*. |
|
Changes Unknown when pulling 39c4bc9 on groyoh:add_tests into * on vinci-proxy:master*. |
Fix coverall test report by removing the token from the
.travis.ymlfile. 3 tests were also added. I'll provide a few more tests in upcoming PRs.