This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Refactoring TourPoint to use react-tiny-popover #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boughtmanatee5
force-pushed
the
2023-02-24-tourpoint-react-tiny-popover-poc
branch
from
caaa921
to
edd2cb5
Compare
|
|
||
| type Props = any; | ||
|
|
||
| new Image().src = 'http://placekitten.com/320/213'; |
There was a problem hiding this comment.
🔥 preloading the image into the browser cache 🔥 I like thattttttt 😮💨
There was a problem hiding this comment.
Copied it from the story Sean wrote!
|
Ohh exciting! thank you for taking this on! |
Boughtmanatee5
force-pushed
the
2023-02-24-tourpoint-react-tiny-popover-poc
branch
from
edd2cb5
to
13b228a
Compare
|
@juliewongbandue Almost have feature parity with the current Tourpoint there's just an alignment bug when the Tourpoint is within a popover! |
Boughtmanatee5
force-pushed
the
2023-02-24-tourpoint-react-tiny-popover-poc
branch
3 times, most recently
from
b607541
to
601c5ee
Compare
Boughtmanatee5
force-pushed
the
2023-02-24-tourpoint-react-tiny-popover-poc
branch
from
601c5ee
to
d469e73
Compare
Co-authored-by: Nathan Brudnik <[email protected]>
|
hey @Boughtmanatee5 ! I just merged this PR that migrates to pnpm: #257, feel free to rebase! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Replaces iris
useAnchorwithreact-tiny-popover. This will allow us to fix issues like https://github.com/vimeo/iris/issues/54 without having to refactor useAnchor. Right now this PR adds no new features to TourPoint it should behave the same as it does currently. Once this is tested we can follow up by adding support for the featuresreact-tiny-popoverhas like passing an array of positions in priority of how we want the be positioned.How it does that
convertAttachToPositionAlignTesting
We should probably have this QA'd pretty throughly since this is an important component.