-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trigger sync page #3652
Update trigger sync page #3652
Conversation
docs/how-tos/trigger-sync.md
Outdated
@@ -28,7 +28,7 @@ You can use it as the basis of your own custom logic. | |||
|
|||
{{% alert title="In this page" color="tip" %}} | |||
|
|||
1. [Use the `CreateShouldSyncReading` function to enable sync](#use-the-createshouldsyncreading-function-to-enable-sync) | |||
1. [Return `should_sync` as a reading from a sensor](#return-should_sync-as-a-reading-from-a-sensor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If builtin data manager is configured with a sync sensor, data manager will only sync on the sync interval if the syncs sensor's Readings
method returns a successful response and that response has a "should_sync"
key
in it with a value of true
.
Otherwise, a builtin data manager will not sync on the sync interval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've adjusted the descriptions below a bit - what you commented on is really only a table of contents - so not really a place to explain this further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change the headers if you have a better suggestion?
Thanks for the code changes - that's a lot cleaner
Co-authored-by: nicksanford <[email protected]>
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3652 |
https://docs-test.viam.dev/3652/how-tos/trigger-sync/#return-should_sync-as-a-reading-from-a-sensor