Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple fixes #14

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Simple fixes #14

wants to merge 9 commits into from

Commits on Nov 1, 2016

  1. Remove non-existent namespace from REPL init 

    This causes a nasty error while loading up the REPL. I was a bit
confused at first but then I realized this ns didn't exist.
    @jvtrigueros
    jvtrigueros committed Nov 1, 2016
    Configuration menu
    Copy the full SHA
    149df62 View commit details
    Browse the repository at this point in the history

  2. Add response-url and user to the meta key 

    Both of these keys are used by post-to-slack and format-result-for-slack
    @jvtrigueros
    jvtrigueros committed Nov 1, 2016
    Configuration menu
    Copy the full SHA
    a07fda3 View commit details
    Browse the repository at this point in the history

  3. Remove the requirement for post-url and obtain it from initial request 

    As per the Slack API documentation, you don't provide a URL to respond
to, instead you are given a URL that you should POST results back to.
    @jvtrigueros
    jvtrigueros committed Nov 1, 2016
    Configuration menu
    Copy the full SHA
    f82df5c View commit details
    Browse the repository at this point in the history

  4. Use format-result-for-slack with correct map structure 

    `format-result-for-slack` expects a certain kind of map. The code has
access to this map already, but a different one is sent instead.
    @jvtrigueros
    jvtrigueros committed Nov 1, 2016
    Configuration menu
    Copy the full SHA
    62de31c View commit details
    Browse the repository at this point in the history

  5. Update sample edn file and README to reflect config requirements 

    `:post-url` shouldn't be mentioned as it is no longer needed
    @jvtrigueros
    jvtrigueros committed Nov 1, 2016
    Configuration menu
    Copy the full SHA
    fdd8dae View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Destructure channel and post-url directly in go-loop bindings

    @jvtrigueros
    jvtrigueros committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    d6a0741 View commit details
    Browse the repository at this point in the history

  2. Create form-params in one expression instead of using let binding

    @jvtrigueros
    jvtrigueros committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    1e622b3 View commit details
    Browse the repository at this point in the history

  3. (condp = ...) is the same as (case ...)

    @jvtrigueros
    jvtrigueros committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    ef6e71b View commit details
    Browse the repository at this point in the history

  4. Destructure params argument in handle-clj

    @jvtrigueros
    jvtrigueros committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    fb0e9cb View commit details
    Browse the repository at this point in the history