Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Sourcemap errors in terminal by default (#71444)" #71868

Merged
merged 1 commit into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export function findSourcePackage({
export function getOriginalCodeFrame(
frame: StackFrame,
source: string | null
): string | null {
): string | null | undefined {
if (!source || isInternal(frame.file)) {
return null
}
Expand Down

This file was deleted.

3 changes: 0 additions & 3 deletions packages/next/src/server/node-environment.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// This file should be imported before any others. It sets up the environment
// for later imports to work properly.

// Import before anything else so that unexpected errors in other extensions are properly formatted.
import './node-environment-extensions/error-inspect'

import './node-environment-baseline'
import './node-environment-extensions/random'
import './node-environment-extensions/date'
Expand Down
228 changes: 0 additions & 228 deletions packages/next/src/server/patch-error-inspect.ts

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { nextTestSetup } from 'e2e-utils'
import { retry } from 'next-test-utils'
import stripAnsi from 'strip-ansi'
import { accountForOverhead } from './account-for-overhead'

const CONFIG_ERROR =
Expand All @@ -27,7 +26,7 @@ describe('app-dir action size limit invalid config', () => {

beforeAll(() => {
const onLog = (log: string) => {
logs.push(stripAnsi(log.trim()))
logs.push(log.trim())
}

next.on('stdout', onLog)
Expand Down Expand Up @@ -116,7 +115,7 @@ describe('app-dir action size limit invalid config', () => {

await retry(() => {
expect(logs).toContainEqual(
expect.stringContaining('Error: Body exceeded 1.5mb limit')
expect.stringContaining('[Error]: Body exceeded 1.5mb limit')
)
expect(logs).toContainEqual(
expect.stringContaining(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ describe(`Dynamic IO Prospective Fallback`, () => {
// we expect the build to fail
}

// TODO: Assert on component stack
expect(next.cliOutput).toContain(
'Route "/blog/[slug]": A component accessed data, headers, params, searchParams, or a short-lived cache without a Suspense boundary nor a "use cache" above it.'
)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
module.exports = {
experimental: {
dynamicIO: true,
serverSourceMaps: true,
},
}

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

34 changes: 0 additions & 34 deletions test/e2e/app-dir/server-source-maps/server-source-maps.test.ts

This file was deleted.

Loading