Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From npms to npmjs registry api #288

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

milovangudelj
Copy link

@milovangudelj milovangudelj commented Jan 31, 2023

Switching to the official npmjs api since npms seems to be outdated and/or abandoned. Production builds fail due to errors in the api calls to npms for recent packages.

Sorry for the messy commit history 😅
It works tho 👀

@vercel
Copy link

vercel bot commented Jan 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
hyper-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 7:52PM (UTC)

@milovangudelj
Copy link
Author

milovangudelj commented Jan 31, 2023

It needs an environement variable called NEXT_PUBLIC_WEBSITE_URL. It's used in the api call that retrieves a package's metadata.

Edit:
Not necessary anymore. I removed it in favor of a static value. It will have to be updated if merged into main.

Copy link

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milovangudelj
Copy link
Author

Can someone from the team review this and potentially merge it?
It's preventing every new theme from being added to the themes list on the website...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants