Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixes Readme #203 #206

Merged
merged 7 commits into from
Sep 14, 2024
Merged

docs: fixes Readme #203 #206

merged 7 commits into from
Sep 14, 2024

Conversation

SteveLasker
Copy link
Contributor

No description provided.

SteveLasker and others added 4 commits July 19, 2024 08:35
Co-authored-by: Orie Steele <[email protected]>
Signed-off-by: steve lasker <[email protected]>
Co-authored-by: Orie Steele <[email protected]>
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (76892d1) to head (e5bc397).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   92.35%   92.47%   +0.12%     
==========================================
  Files          12       12              
  Lines        1622     1622              
==========================================
+ Hits         1498     1500       +2     
+ Misses         68       66       -2     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveLasker SteveLasker mentioned this pull request Sep 13, 2024
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Non blocking comments:

  • Maybe add a full stop at the end of the sentence.
  • Also, "managed through github" seems superfluous.

@SteveLasker SteveLasker added this to the v1.4.0 milestone Sep 13, 2024
README.md Outdated Show resolved Hide resolved
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker
Copy link
Contributor Author

Thanks, @thomas-fossati, I've made those changes.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title Fixes Readme #203 docs: fixes Readme #203 Sep 14, 2024
@SteveLasker SteveLasker merged commit 4162f36 into main Sep 14, 2024
6 checks passed
@SteveLasker SteveLasker deleted the steve/current-release-readme branch September 14, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants