Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add examples for detached payload #205

Merged
merged 1 commit into from
Sep 13, 2024
Merged

test: add examples for detached payload #205

merged 1 commit into from
Sep 13, 2024

Conversation

shizhMSFT
Copy link
Contributor

Add examples of signing and verifying with detached payload for #195

@shizhMSFT shizhMSFT mentioned this pull request Sep 6, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (2b6f94f) to head (31fa505).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   92.04%   92.35%   +0.31%     
==========================================
  Files          12       12              
  Lines        1973     1622     -351     
==========================================
- Hits         1816     1498     -318     
+ Misses        108       68      -40     
- Partials       49       56       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveLasker
Copy link
Contributor

👀's from @veraison/go-cose-maintainers please

thomas-fossati
thomas-fossati approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

OR13
OR13 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem like they are worth merging even if we provide a better convenience API in the future.

@SteveLasker SteveLasker mentioned this pull request Sep 13, 2024
Open
@OR13 OR13 added this to the v1.4.0 milestone Sep 13, 2024
SteveLasker
SteveLasker approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for clarity of #197

@SteveLasker SteveLasker merged commit 76892d1 into veraison:main Sep 13, 2024
4 checks passed
@shizhMSFT shizhMSFT deleted the example_detached branch September 14, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-fossati thomas-fossati thomas-fossati approved these changes

@OR13 OR13 OR13 approved these changes

@SteveLasker SteveLasker SteveLasker approved these changes

@henkbirkholz henkbirkholz Awaiting requested review from henkbirkholz henkbirkholz is a code owner

@qmuntal qmuntal Awaiting requested review from qmuntal qmuntal is a code owner

@roywill roywill Awaiting requested review from roywill roywill is a code owner

@setrofim setrofim Awaiting requested review from setrofim setrofim is a code owner

@SimonFrost-Arm SimonFrost-Arm Awaiting requested review from SimonFrost-Arm SimonFrost-Arm is a code owner

@yogeshbdeshpande yogeshbdeshpande Awaiting requested review from yogeshbdeshpande yogeshbdeshpande is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shizhMSFT @SteveLasker @OR13 @thomas-fossati