This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Add and update HTML transformers [TS-311] #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredplanter
changed the title
jaredplanter
commented
Aug 11, 2021
|
|
||
| def to_slack | ||
| # Filter out all remaining < > tags except for Slack links (<http://url|text> or <http://url>) | ||
| input.gsub(/<(.[^http][^|]*?)>/, '') |
There was a problem hiding this comment.
I wrote this transformer to clean up remaining HTML tags for now with the plan of replacing it with some sort of "cleaner" class that does this and eliminates the spacing bug. As mentioned here.
* Add hyperlink transformer to convert HTML hyperlinks to Mrkdwn links * Add line break transformer to convert HTML line breaks to new lines (\n) * Add unsupported transformer to remove remaining html tags, excluding Slack's link tags * Update the bold transformer to include the semantic <strong> tag * Update the italics transformer to include the semantic <em> tag * Update specs
jaredplanter
force-pushed
the
improve-html-tag-support
branch
from
4e8774c
to
3c8cbaa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes are a part of TS-311 and get us most of the way there with the exception of this bug which will be addressed with this ticket. Once that is resolved and we are satisfied we can make this a pull request against the official repository for slack_transformer.
Until then we will be pointing to this branch in our fork for the implementation.
Checklist
Add hyperlink transformer to convert HTML hyperlinks to Mrkdwn links
Add line break transformer to convert HTML line breaks to negative space until we can get
\nto workAdd unsupported transformer to remove remaining html tags, excluding Slack's link tags
Update the bold transformer to include the semantic
<strong>tagUpdate the italics transformer to include the semantic
<em>tagUpdate specs