Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make drift term available #701

Merged
merged 9 commits into from
Sep 5, 2024
Merged

feat: make drift term available #701

merged 9 commits into from
Sep 5, 2024

Conversation

Jiajia-Cui
Copy link
Contributor

Description

@Jiajia-Cui Jiajia-Cui requested a review from a team as a code owner August 30, 2024 12:21
Copy link
Collaborator

@cdummett cdummett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pass this field through into the price process generator in this PR as well please.

At the moment this gives the illusion varying drift will modify the underlying OU price process but actually it will still be defaulting to zero.

vega_sim/scenario/amm/registry.py Outdated Show resolved Hide resolved
vega_query/visualisations/overlay.py Outdated Show resolved Hide resolved
vega_query/visualisations/overlay.py Outdated Show resolved Hide resolved
vega_query/visualisations/overlay.py Outdated Show resolved Hide resolved
vega_query/visualisations/overlay.py Outdated Show resolved Hide resolved
vega_query/visualisations/overlay.py Outdated Show resolved Hide resolved
vega_query/visualisations/overlay.py Show resolved Hide resolved
vega_query/visualisations/overlay.py Outdated Show resolved Hide resolved
@Jiajia-Cui Jiajia-Cui merged commit cde315a into develop Sep 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants