Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding port setting for metrics to fuzz test run #517

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

TomMcL
Copy link
Contributor

@TomMcL TomMcL commented Sep 29, 2023

Description

Adding ability to manually configure port for metrics to a known fixed port on fuzz testing runs

Testing

Ran locally and port was as configured

Breaking Changes

run_fuzz_test script is changed so proc files attempting to call it will need slight updating

Closes

@TomMcL TomMcL requested a review from a team as a code owner September 29, 2023 14:33
@TomMcL TomMcL self-assigned this Sep 29, 2023
Copy link
Contributor

@davidsiska-vega davidsiska-vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, from my limited understanding.

Passing tests locally.

@TomMcL TomMcL merged commit 3db969f into develop Sep 29, 2023
5 of 7 checks passed
@TomMcL TomMcL deleted the feat/metrics_predictable_port branch September 29, 2023 15:21
daniel1302 pushed a commit that referenced this pull request Oct 5, 2023
* feat: Adding port setting for metrics to fuzz test run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants