Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle genesis changes #504

Merged
merged 5 commits into from
Sep 5, 2023
Merged

feat: handle genesis changes #504

merged 5 commits into from
Sep 5, 2023

Conversation

TomMcL
Copy link
Contributor

@TomMcL TomMcL commented Sep 5, 2023

Description

Fixes for core changes and better shutdown to avoid infinite waits

Testing

Tested locally. Now works and correctly closes on errors

Breaking Changes

None

Closes

@TomMcL TomMcL self-assigned this Sep 5, 2023
@TomMcL TomMcL requested a review from a team as a code owner September 5, 2023 09:52
cdummett
cdummett reviewed Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@cdummett cdummett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but could we add the new network parameters to the genesis file as a part of this PR with the proposed mainnet values?

@TomMcL TomMcL requested a review from cdummett September 5, 2023 14:59
@TomMcL TomMcL merged commit 715b9d6 into develop Sep 5, 2023
6 checks passed
@TomMcL TomMcL deleted the feat/handle_gen_changes branch September 5, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdummett cdummett cdummett approved these changes

Assignees

@TomMcL TomMcL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomMcL @cdummett