Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iceberg order #461

Merged
merged 3 commits into from
Jul 21, 2023
Merged

feat: iceberg order #461

merged 3 commits into from
Jul 21, 2023

Conversation

cdummett
Copy link
Collaborator

Description

PR updates market-sim order submissions with iceberg functionality.

Testing

Test added and passing locally.

Breaking Changes

None

@cdummett cdummett added the enhancement New feature or request label Jul 20, 2023
@cdummett cdummett self-assigned this Jul 20, 2023
@cdummett cdummett marked this pull request as ready for review July 20, 2023 12:15
@cdummett cdummett requested a review from a team as a code owner July 20, 2023 12:15
Copy link
Contributor

@TomMcL TomMcL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vega_sim/service.py Show resolved Hide resolved
@cdummett cdummett merged commit 00cc6d0 into develop Jul 21, 2023
6 checks passed
@cdummett cdummett deleted the feat/iceberg_orders branch July 21, 2023 09:31
@bwallacee bwallacee restored the feat/iceberg_orders branch July 24, 2023 07:53
@bwallacee bwallacee deleted the feat/iceberg_orders branch September 18, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants