Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trading): ticket submit button #6976

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(trading): ticket submit button #6976

merged 1 commit into from
Sep 20, 2024

Conversation

asiaznik
Copy link
Contributor

Related issues 🔗

Closes #6974

Description ℹ️

  • adds "loading" state to the ticket submit button
  • gets the colour based on the side and changes only when needs to Connect or Deposit

Demo 📺

Screen.Recording.2024-09-20.at.14.47.46.mov

Technical 👨‍🔧

Instead of rendering 3 buttons it is now combined into one to avoid strange flickering

@asiaznik asiaznik requested a review from a team as a code owner September 20, 2024 12:52
Copy link

@mattrussell36 mattrussell36 merged commit 56c72cb into develop Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flicker of colour change on the deal ticket button
2 participants